Add keywords to WMS and WFS #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jahow
approved these changes
Jul 16, 2024
|
@jahow Thanks! Looks like I might need to run prettier to sort out some formatting. I'll do that and add another commit |
|
Indeed I forgot the CI wasn't running on fork PRs. I'll rerun it as soon as changes are pushed, thanks! |
|
All good! I'm merging 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds keywords to the WMS and WFS layers/featuretypes output, in the same way that keywords are added to the top level capability documents.
One of the test fixtures (fixtures/wms/capabilities-brgm-1-1-1.xml) had to be modified to make them consistent between versions (keywords didn't appear in one version that did in another). I felt changing the fixture was safer but it could be changed to instead change the test to handle the differences.